Re: yet another kernel panic

On 2004-10-09, Matthew Dillon <[e-mail]> wrote:
>
>:On 2004-09-06, Matthew Dillon <[e-mail]> wrote:
>:>:im running almost latest current (from yesterday) with that patch and am
>:>:wondering if there are any test apps to check if the patch works or should i
>:>:just wait if it shows up by itself?
>:...
>:
>:i got another kernel panic, dont know if its related or not, but i uploaded the
>:memory dump to leaf:~rumko/memory_dumps/8.10.2004/
>
>     Rum, you aren't running that patch I emailed you last time (which has
>     since gone into the tree).  I verified it by disassembling vm_waitproc():
>
> 0xc02c81bc <vm_waitproc>:       push   %ebp
> 0xc02c81bd <vm_waitproc+1>:     mov    %esp,%ebp
> 0xc02c81bf <vm_waitproc+3>:     push   %ebx
> 0xc02c81c0 <vm_waitproc+4>:     mov    0x8(%ebp),%ebx
> 0xc02c81c3 <vm_waitproc+7>:     push   %ebx
> 0xc02c81c4 <vm_waitproc+8>:     call   0xc0362bec <cpu_proc_wait>
> 0xc02c81c9 <vm_waitproc+13>:    push   %ebx
> 0xc02c81ca <vm_waitproc+14>:    call   0xc02c90a0 <vmspace_exitfree>
> 0xc02c81cf <vm_waitproc+19>:    mov    0xfffffffc(%ebp),%ebx
> 0xc02c81d2 <vm_waitproc+22>:    leave  
> 0xc02c81d3 <vm_waitproc+23>:    ret    
>
>     There should be a 'movl   $0x0,0x1c(%ebx)' in there that corresponds
>     to the 'p->p_stats = NULL' line that was added to vm_waitproc() in
>     vm/vm_glue.c 1.28, and there isn't.
>
>     I recommend upgrading to DragonFly_Stable.  It has that patch plus a 
>     number of other bugs fixes.
>     
> 					-Matt
> 					Matthew Dillon 
> 					<[e-mail]>

but i should have that patch
copy/pasted from the source file:

vm_waitproc(struct proc *p)
{
        p->p_stats = NULL;
        cpu_proc_wait(p);
        vmspace_exitfree(p);    /* and clean-out the vmspace */
}