[issue1734] savecore is not picking up dumpdev if the device is not

Alexander Polakov <[e-mail]> added the comment:

I was wrong. savecore doesn't look on dumpdev at all.

We can do something like this, I guess:

diff --git a/etc/rc.d/savecore b/etc/rc.d/savecore
index bc62b77..f55aff1 100644
--- a/etc/rc.d/savecore
+++ b/etc/rc.d/savecore
@@ -58,7 +58,7 @@ savecore_start()
 {
        if [ X$dumpdev != X ]; then
                echo "Checking for core dump..."
-               savecore ${savecore_flags} ${DUMPDIR}
+               savecore ${savecore_flags} ${DUMPDIR} ${dumpdev}
                return ${RC_CONFIGURED}
        fi
 }

diff --git a/share/man/man5/rc.conf.5 b/share/man/man5/rc.conf.5
index c7128fb..4329fe5 100644
--- a/share/man/man5/rc.conf.5
+++ b/share/man/man5/rc.conf.5
@@ -2315,7 +2315,9 @@ to turn this behavior off.
 Indicates the device (usually a swap partition) to which a crash dump
 should be written in the event of a system crash.
 The value of this variable is passed as the argument to
-.Xr dumpon 8 .
+.Xr dumpon 8
+and
+.Xr savecore 8 .
 To disable crash dumps, set this variable to
 .Dq Li NO .
 .It Va dumpdir

_____________________________________________________
DragonFly issue tracker <[e-mail]>
<http://bugs.dragonflybsd.org/issue1734>
_____________________________________________________