--nextPart1315113.8ogX5q7Khe
Content-Type: text/plain;
charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
On Sunday, 9. January 2005 18:35, Larry Lansing wrote:
> Sorry, newbie at work. Resubmitting as unified diff, with only
> the renamed locals version of camcontrol.c. Thanks for the
> patience.
> +WARNS=3D 6
should be WARNS?=3D 6
> -static int parse_btl(char *tstr, int *bus, int *target, int *lun,
> - cam_argmask *arglist);
> +static int parse_btl(char *tstr, int *mybus, int *mytarget, int *mylun,
> + cam_argmask *myarglist);
> static int dorescan_or_reset(int argc, char **argv, int rescan);
> -static int rescan_or_reset_bus(int bus, int rescan);
> -static int scanlun_or_reset_dev(int bus, int target, int lun, int scan);
> +static int rescan_or_reset_bus(int mybus, int rescan);
> +static int scanlun_or_reset_dev(int mybus, int mytarget, int mylun, int
> scan);
I would remove parameter names here:
s/ *[[:alnum:]]*\([,)]\)/\1/g
[...]
> /* Print the raw mode page data with newlines each 8 bytes. */
> - for (index =3D 0; index < mph->page_length; index++) {
> - printf("%02x%c",mode_pars[index],
> - (((index + 1) % 8) =3D=3D 0) ? '\n' : ' ');
> + for (mode_idx =3D 0; mode_idx < mph->page_length; mode_idx++) {
> + printf("%02x%c",mode_pars[mode_idx],
more space after commas! :)
cheers
simon
=2D-=20
/"\
\ /
\ ASCII Ribbon Campaign
/ \ Against HTML Mail and News
--nextPart1315113.8ogX5q7Khe
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)
iD8DBQBB4XB2r5S+dk6z85oRAortAKCKoUKFeuSdN6HCsWg+xXR96TlChgCgtTJo
2eYC7QIWO0fzWvD2cKBDKV4=
=O5ji
-----END PGP SIGNATURE-----
--nextPart1315113.8ogX5q7Khe--