Re: [PATCH] Fix NKPT kernel config option

On Thursday, September 01, 2011 3:46:43 pm Robert Millan wrote:
> Hi John,
> 
> Thanks for adding an NKPT kernel config option (r225194), but this
> doesn't seem to work unless opt_pmap.h is included, see attached
> patch.
> 
> Without this include, there's no garantee that the NKPT definition code:
> 
> #ifndef NKPT
> #define NKPT            32
> #endif
> 
> will use the value specified in config.  Or worse, it may even use
> different values for different .c files.
> 
> -- 
> Robert Millan

In general we force the relevant C files to use opt_*.h includes and avoid
nested includes of those in headers.  Do you know of any C files that do
are using NKPT (or values derived from it) without including opt_pmap.h?  I 
thought they were all covered in the commit.

-- 
John Baldwin
_______________________________________________
[e-mail] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[e-mail]"