--JQ29orswtRjjfiJM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Jun 09, 2014 at 07:27:43PM -0400, Glen Barber wrote:
> On Tue, Jun 10, 2014 at 02:15:06AM +0300, Konstantin Belousov wrote:
> > On Sun, Jun 08, 2014 at 04:36:45PM -0400, Glen Barber wrote:
> > > On Sun, Jun 08, 2014 at 01:33:31PM -0700, Adrian Chadd wrote:
> > > > Now, as for how much bloat it adds to the CD images...
> > > >=20
> > >=20
> > > Enough that it will be turned off for the CDs.
> >=20
> > I wanted to answer that we should split the question into two,
> > one is whether to enable tests installation by default for buildworld
> > (and I answered no there), another is whether to ship tests with the
> > installation media, both on releases and snapshots.
> >=20
> > I think that we should do the later, if not on CD, then on DVD and for
> > ftp installs. This would mean that there is one more customization
> > for the release build process, but I do not think that the release
> > build structure requires significant changes.
> >=20
>=20
> We are dangerously teetering every time an option to add "just one more"
> thing to the CD is committed to being unable to fall below the 685MB
> size (which I understand is what FreeBSDMall needs for the CDs they
> produce).
>=20
> So, as our src/ and ports/ trees grow, the room we have left is
> shrinking fast. I think it is not feasible to ship the tests on the CD,
> but I do agree they can be shipped on the DVD.
>=20
> Julio has submitted a review request for this to make a tests.txz
> distribution, which can then be excluded for the bootonly.iso and
> disc1.iso, but kept for the dvd.iso.
>=20
> https://phabric.freebsd.org/D198
>=20
> I am building a test release build with this change now, but I am aware
> of one immediate problem that will be encountered - if we default
> WITH_TESTS=3D1, the running userland on the bootonly.iso and disc1.iso
> (used for the installer) will also include the tests.
>=20
> This is because we do not evaluate the value of WITH_TESTS=3D, but only
> that it is defined. This is also a problem for the debug.txz with
> WITH_DEBUG_FILES=3D1 for the buildworld/buildkernel, but
> WITHOUT_DEBUG_FILES=3D1 for the bootonly.iso and disc1.iso creation,
> because we cannot set both.
>=20
> Some of the later commits to a projects/ branch to work on allowing the
> debug.txz to be fetched from FTP (or via the netinstall) illustrates the
> problem and some very hackish workarounds I have tried.
>=20
> https://svn.freebsd.org/base/projects/release-debugdist/
>=20
After reviewing Julio's proposed changes, I realize that there is a way
to avoid populating /usr/tests when building the on-disc filesystem.
I think this will also apply to the WITH_DEBUG_FILES=3D1 case mentioned.
It seems I cannot apply an update to another differential review (or
I am just doing it wrong), so have created a new differential here:
https://phabric.freebsd.org/D202
Glen
--JQ29orswtRjjfiJM
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCAAGBQJTlyoyAAoJELls3eqvi17Q/2gP/Rao5rmkbCmscQgnl7JH8AjP
TjYlNtGA6FgHlO2+5g8U8kUNJtUMf80IO/hV4sqZAE4+/XeiIXld5B1ndGhxqG9p
cU7mH3UeHmA1cFWSFRqXrrQ3RnJ9f7tvliSoH4vwppn2eG6aCPixVR5447C5bGLW
Q8D7fWsm7NcOP88JR9hWNwBtZXD1LwaGKfphGHIHAF+cylNKycKaLRT0ZXnLIzYj
RHAwDQT5Ndukt1tFC+IzvTe8I9bjv5BvmhTAg+MY2siALnRwy3xaVtlY1qiEbGdt
DTirsFo3Iz6iaMyXs1tV67eFVQSIvGqFZz+X+6Ad2kKy61w2baFaq1MLWIMDpwoS
HSq4nCB04KYBEnMsYGZYH5q+f1//yAyfivw3lNC5RRnnyPyCxzDzX9tSv/a5ibuo
4i0y1uTM+OmzbFIRrA5bsGMBbcEcp30xIjbO+NoYirTF2csTaQt2RcY08x4DZuiJ
sq0PnBPggaWCf4UH8ApFhlRROdp6mdbrnTyHV/41kshqlTP4dJWUy/QMTZc6HnLW
j6dsfxJZ4Wkwj2PVgWVf/KfZnyjsM/JPxHamUeNuGdd8pynR9PagJFbQ2knBVnmO
m54ARh6Of+6izWe9EEMSVHj4u4MnoPWtOFS8uDQV5rLxRV22xKRklT4VXCfIFTL/
7bcRJYki1hRbuaPc26SL
=2MfQ
-----END PGP SIGNATURE-----
--JQ29orswtRjjfiJM--