Re: cvs commit: ports/shells/zsh/files patch-Src_watch.c

--S1BNGpv0yoYahz37
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Nov 13, 2011 at 10:45:35AM +0000, Chris Rees wrote:
> On 13 November 2011 09:56, Baptiste Daroussin <[e-mail]> wrote:
> > bapt =A0 =A0 =A0 =A02011-11-13 09:56:08 UTC
> >
> > =A0FreeBSD ports repository
> >
> > =A0Added files:
> > =A0 =A0shells/zsh/files =A0 =A0 patch-Src_watch.c
> > =A0Log:
> > =A0- Fix build for badly upgraded systems which have both utmp.h and ut=
mpx.h
> >
> > =A0PR: =A0 =A0 =A0 =A0 =A0 =A0 ports/156263 =A0http://www.FreeBSD.org/c=
gi/query-pr.cgi?pr=3D156263
> > =A0Submitted by: =A0 Matthew Cashdollar <[e-mail]>
> > =A0Feature safe: =A0 yes
> >
>=20
> Fixing it here will only mask the problem-- why are we adding a fix to
> support a broken system?
>=20
> The proper solution is to rm utmp.h in that system, is it not?
>=20
> I suggest a different patch at [1].
>=20
> Chris
>=20
> [1] http://www.bayofrum.net/~crees/patches/zsh-utmpx-fix.diff.txt
> [removing the patchfile too]

Well no I don't think, or you would have to add the same patch in lots of p=
orts.

In fact, I have been pondering for long what would be the best fix for this=
=2E And
if I need to provide a fix.
Given that some people can use zsh for root (as I do :)) I think being able=
 to
rebuild zsh a clean way before doing the make delete-old is nice, that is w=
hy I
did a fix that way.

regards,
Bapt

--S1BNGpv0yoYahz37
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)

iEYEARECAAYFAk7A9pkACgkQ8kTtMUmk6EyFtACgmroQK9EEXdUnlce1smh6BtFd
Hh8AoIkh1WDwNN+6QKttXx6TDUVFCv6G
=XyKj
-----END PGP SIGNATURE-----

--S1BNGpv0yoYahz37--