RE: Audio driver template

> > http://people.freebsd.org/~cg/template.c
> >
> > Thought I would take a look at the audio driver template as
> > part of my task to modernize drivers, soc2007. I would simplify
> > the read and write functions to avoid using the bus tag and
> > handle, but I'm not sure what else to do to bring it up to date.
> >
> > How else can it be improved?
>=20

> And you should clarify what kind of improvements are valid for your =20
> SoC work. Somehow I doubt that adding shiny new features (like hps =20
> suggested) is part of the goal for your work. I think it's more like =20
> bringing existing drivers up-to-par with currently available generic =20
> driver interfaces, isn't it?
>=20
> I also think examples for suspend/resume stuff should be added. =20
> /sys/dev/sound/pci/atiixp.c has suspend and resume methods if=20
> you want =20
> an example.
>=20
> You could also review the locking, as it changed a little bit =20
> recently, I think.
>=20
> Apart from the atiixp driver the envy42, emu10kx and HDA drivers can =20
> also serve as examples for what is the most current in the sound =20
> subsystem in FreeBSD. Maybe you can gain some more hints from=20
> them (I =20
> think the template is not very up-to-date compared to them).

emu10kx is bad example, because it uses a lot of "hacks", like=20
ac97 codec emulation.


Yuriy.

_______________________________________________
[e-mail] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "[e-mail]"