Re: config(8) patch for review for src dir handling

On Sun, Dec 23, 2007 at 10:40:39AM +0100, Dag-Erling Sm鷨grav wrote:
> Ed Maste <[e-mail]> writes:
> > Right now config(8) calls realpath("../..", ... to find the src path
> > to write into the kernel Makefile.  I want to change this to use $PWD
> > with the last two path components removed, assuming it's the same dir
> > as ../.. .

> I'm worried that your patch assumes that $PWD is present and correct,
> for which there is no guarantee.  What happens if you use getcwd()
> instead of getenv("PWD")?

getcwd() does not use $PWD, it returns a pathname without symlinks.
So that would lead to the original behaviour.

A better way could be to use $PWD if it is set and an absolute logical
pathname referring to the current directory, as in src/bin/pwd/pwd.c .

-- 
Jilles Tjoelker
_______________________________________________
[e-mail] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "[e-mail]"