On 07/16/14 12:57, Brooks Davis wrote:
> On Wed, Jul 16, 2014 at 12:13:48PM -0700, Sean Fagan wrote:
>> On Jul 16, 2014, at 10:07 AM, Brooks Davis <brooks@freebsd.org> wrote:
>>
>>> The vast majorify of the diff is make debugging garbage that looks like
>>> it was committed by accident. I won't provided any detailed review
>>> of the current patch except to say that there are a lot of apparently
>>> redundent instances of setting META_CATEGORY in Makefiles and still
>>> quite a lot of instances of .EXPORTVAR: META_CATEGORY.
>> Okay. Again, my apologies about that; I've excised it, and removed all
>> of the EXPORTVAR directives, even the ones that had been commented out.
>> (Note that the patch includes a change to xinstall, that is commented out; that's
>> because I think I still like the concept of it, to at least some degree, and didn't
>> want to forget where I put it. But it *is* commented out, and so the functionality
>> is simply not there.)
>>
>> Without my idiotic error, the diff is much smaller -- just under 50,000 bytes. However,
>> rather than include it again, I've replaced the file at http://earth.kithrup.com/~sef/auto-diffs.txt
>> for everyone's perusal.
> Some comments with limited context:
>
> In Makefile.inc1 you write:
>
> LIB32WMAKEENV+= META_CATEGORY=compat32
>
Picking a random example: how is this different/better than the existing
DISTRIBUTION variable?
-Nathan
_______________________________________________
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"