RE: [PATCH] Hold PROC lock while accessing proc's pargs

On 29-Mar-2002 Jon Mini wrote:
>> alfred      2002/03/27 13:36:18 PST
>> 
>>   Modified files:
>>     sys/sys              proc.h 
>>     sys/compat/svr4      svr4_misc.c 
>>     sys/kern             kern_exec.c kern_exit.c kern_fork.c 
>>                          kern_proc.c 
>>   Log:
>>   Make the reference counting of 'struct pargs' SMP safe.
>>   
>>   There is still some locations where the PROC lock should be held
>>   in order to prevent inconsistent views from outside (like the
>>   proc->p_fd fix for kern/vfs_syscalls.c:checkdirs()) that can be
>>   fixed later.
>>   
>>   Submitted by: Jonathan Mini <[e-mail]>
>>   
>>   Revision  Changes    Path
>>   1.43      +1 -2      src/sys/compat/svr4/svr4_misc.c
>>   1.158     +2 -6      src/sys/kern/kern_exec.c
>>   1.153     +1 -2      src/sys/kern/kern_exit.c
>>   1.142     +1 -2      src/sys/kern/kern_fork.c
>>   1.122     +5 -7      src/sys/kern/kern_proc.c
>>   1.213     +51 -0     src/sys/sys/proc.h
> 
> 
> This patch does that:
> 
>       http://www.haikugeek.com/freebsd/pargs.diff

You don't need PROC_LOCK for p_comm, so you can drop it prior to the
sbuf_printf.

-- 

John Baldwin <[e-mail]>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to [e-mail]
with "unsubscribe freebsd-smp" in the body of the message