--Rn7IEEq3VEzCw+ji
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Apr 08, 2014 at 11:03:02PM -0400, Glen Barber wrote:
> On Tue, Apr 08, 2014 at 07:56:25PM -0700, Jeremy Chadwick wrote:
> > (Please keep me CC'd as I'm not subscribed to freebsd-stable@)
> >=20
> > Root cause appears related to r264014:
> >=20
> > http://svnweb.freebsd.org/base/stable/9/Makefile.inc1?annotate=3D264014
> >=20
> > My src/ correlates with r264285, so it seems this issue has been
> > lingering for a week now. Did anyone truly test this fully before
> > committing? (Yes I read the commit message; consider me doubtful)
> >=20
>=20
> Of course. But it seems 'delete-old' target did not get thoroughly
> tested.
>=20
> > There is no /usr/obj/usr/src/sys/sys/param.h. Maybe what's wanted is
> > /usr/obj/usr/src/tmp/sys/sys/param.h or
> > /usr/obj/usr/src/include/osreldate.h (both of which exit and define
> > __FreeBSD_version)?
> >=20
> > There is no /usr/obj/usr/src/release, so I don't know what any of that
> > is about.
> >=20
> > I can make a PR for this if asked.
> >=20
>=20
> Not necessary. I need some time to test some changes, but I do see what
> is wrong.
>=20
Hmm, maybe I do not see quite what is wrong.
Can you show me output of 'uname -U' and 'svn info /usr/src' ?
When I run 'delete-old' against stable/9@r264148, I do see some unwanted
noise, but nothing nearly as intrusive as you see.
root@grind:/usr/src # make delete-old
>>> Removing old files (only deletes safe to delete libs)
awk: can't open file /usr/obj/usr/src/sys/sys/param.h
source line number 1
"/usr/src/Makefile.inc1", line 137: warning: "awk '/^#define[[:space:]]*__F=
reeBSD_version/ { print $3 }'
/usr/obj/usr/src/sys/sys/param.h" returned non-zero status
>>> Old files removed
>>> Removing old directories
awk: can't open file /usr/obj/usr/src/sys/sys/param.h
source line number 1
"/usr/src/Makefile.inc1", line 137: warning: "awk '/^#define[[:space:]]*__F=
reeBSD_version/ { print $3 }'
/usr/obj/usr/src/sys/sys/param.h" returned non-zero status
>>> Old directories removed
To remove old libraries run '/usr/obj/usr/src/make.amd64/make delete-old-li=
bs'.
Glen
--Rn7IEEq3VEzCw+ji
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)
iQIcBAEBCAAGBQJTRLwGAAoJELls3eqvi17QGUYP/Avy+RUuS6E09V8Ed4kKzR1z
KvcDivKL/QX/rlxThNANRzIrEDIZiGHK5UKzxEYi0noh8elzbFrMk6fWyBwetJ2r
GJYqp4kC7iwNRkGN3VNSgcqXmAAYDA5cCumpZQV5UZm5EdYb16g1bMwoMETB9I70
xRLm0SqVKwBxMs2OOr6a0xDJxcbc4fdympgyZl4pbaLhYGYR2LSqnpD+lzj6stLQ
KjWeGuJwymwnnpJlcQgiuthQPoZeE7LK8wAYxPuQIQSEyCQ3cAZ4T5xBTfxeCH9X
FvvejhLFGKxV1UL6BHjhACAb03JPhH0VL1V4JrH/ErpJDS1cl3WvDgQY89A79LZS
8hHDX9rkVeYxfFKHJcqOLvXPXqQQ/siQWY2vidqyCuAVTuihmvoP4HNFzo2VkUb0
mUnLFKqlvcP885YRcp98not6OMLxQfWIw9tK2OstTv9UUuGEvMkCpyxbHq6ubFx0
RcufWiAZyG75tMScZke5fgLwRzdiSpoDwTH96OZASi2gJ5tn7qpBRHvZKOuYq8hy
UWUdkz9i8awdW8P+Tse7N6YedTw5vQJka6D01VD/7AW6ec/TBGg+D9WjgH2v0w8I
GsEW2imbPuRRB1FXGdztpDI6goxKBM13aZiDeRDZiVr8QIqMc2Cia1NOmYu3gPdr
fBqeA4tFK5kwC4bizLoj
=FZ7k
-----END PGP SIGNATURE-----
--Rn7IEEq3VEzCw+ji--