Re: [HEADS-UP] Problem with clang in 9-stable [was: r268244

--Apple-Mail=_BFB754AE-3DB6-4CC1-A413-D49D8B2ACC46
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On 05 Jul 2014, at 14:49, David Chisnall <[e-mail]> =
wrote:
> On 4 Jul 2014, at 19:18, David Wolfskill <[e-mail]> wrote:
>=20
>> clang -O2 -pipe  -std=3Dgnu99 -Qunused-arguments  -fstack-protector =
-Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter =
-Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith =
-Wno-uninitialized -Wno-pointer-sign -Wno-empty-body =
-Wno-string-plus-int -Wno-unused-const-variable =
-Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality =
-Wno-unused-function -Wno-enum-conversion  -o sysctl sysctl.o=20
>=20
> This compile line is turning off a lot of warnings.  In particular, =
-Wno-uninitialized and -Wno-parentheses-equality are likely to hide =
warnings that refer to real errors.

Interestingly, -Wno-uninitialized has been in bsd.sys.mk since r76861,
and the accompanying comment ("XXX Delete -Wuninitialized by default for
now -- the compiler doesn't always get it right") has never been
changed. :-)

It is probably time to re-enable that warning after 13 years, at least.

I'm not so sure about -Wno-parentheses-equality, because that might give
quite a few false positives, especially in old, contributed code.

-Dimitry


--Apple-Mail=_BFB754AE-3DB6-4CC1-A413-D49D8B2ACC46
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)

iEYEARECAAYFAlO3+KYACgkQsF6jCi4glqOwnACbBHvEd5jjCn21OaTqw4Yt2xnb
kW4AmwVuMdRnWZaarzsr4FmKaT2RwSQ/
=T8v3
-----END PGP SIGNATURE-----

--Apple-Mail=_BFB754AE-3DB6-4CC1-A413-D49D8B2ACC46--