On Jul 2, 2012, at 9:32 AM, Marcel Moolenaar <marcel@xcllnt.net> wrote:
>=20
> On Jul 2, 2012, at 8:28 AM, Baptiste Daroussin wrote:
>=20
>> Author: bapt
>> Date: Mon Jul 2 15:28:50 2012
>> New Revision: 237997
>> URL: http://svn.freebsd.org/changeset/base/237997
>>=20
>> Log:
>> New build KNOB: WITHOUT_PKGBOOTSTRAP to condition building of usr.sbin/pk=
g
>> Do not condition usr.sbin/pkg building on WITHOUT_PKGTOOLS anymore, so th=
at users can
>> remove the old pkg_* tools without removing the pkgng boostrap
>=20
> Oh, and:
>=20
>> Added: head/tools/build/options/WITHOUT_PKGBOOSTRAP
>=20
> You have a typo in the options filename as well.
>=20
> With all those mistakes and typos, I cannot escape the notion that this is=
a
> rushed commit or at least that it didn't get the attention it should have
> gotten. Worse, it wasn't caught by your mentor.
>=20
> des: please give reviews more attention
> bapt: it sometimes helps to review your own patches as if they weren't you=
rs.
> you won't catch as much as a real 3rd party would, because they are
> still your patches and you're bound to overlook stuff, but at least
> you may catch some of the boneheaded stuff.
The other thing is that src.conf(5) wasn't regenerated after the commit (the=
knob and the src.conf commit should be done separately to as src.conf gener=
ation is driven by $Revision$ in the knob file.
Thanks,
-Garrett=
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"