mtree -L is broken due to unneded type=link additions to BSD.*.dist

I found commit which broke 'mtree -L', it is
BSD.usr.dist v1.293 (des) and BSD.local.dist v1.108 (des)

Symptoms are:
mtree -eU -L -f /usr/src/etc/mtree/BSD.usr.dist -p /usr
share/nls/en_US.US-ASCII changed
        type expected link found dir
share/nls/POSIX changed
        type expected link found dir

This commit is not only broke 'make hierarchy', it is completelly unneded,
because those symlinks are already created by /usr/src/etc/nls.alias 
processing. Please back it out.

-- 
Andrey Chernov | http://ache.pp.ru/
_______________________________________________
[e-mail] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[e-mail]"

> -------------------------------------------------------------------------- <

發信人: [e-mail] (Dag-Erling Sm鷨grav), 看板: FB_current
標  題: Re: mtree -L is broken due to unneded type=link additions to
發信站: NCTU CSIE FreeBSD Server (Tue Mar 30 09:19:42 2004)
轉信站: ptt!FreeBSD.csie.NCTU!not-for-mail

Andrey Chernov <[e-mail]> writes:
> This commit is not only broke 'make hierarchy', it is completelly unneded,
> because those symlinks are already created by /usr/src/etc/nls.alias=20
> processing. Please back it out.

It does not break 'make hierarchy', unless you have uncommitted
patches which add -L to the mtree command line.

The BSD.local.dist commit fixes a problem which has plagued port
maintainers for years (as witnessed by the number of times people have
inadvertantly committed plists that included share/nls/POSIX and
share/nls/en_US.US-ASCII).  I committed the same patch to BSD.usr.dist
for symmetry, since BSD.local.dist is supposed to be (very nearly) a
subset of BSD.usr.dist.

DES
--=20
Dag-Erling Sm=F8rgrav - [e-mail]
_______________________________________________
[e-mail] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[e-mail]"

> -------------------------------------------------------------------------- <

發信人: [e-mail] (Andrey Chernov), 看板: FB_current
標  題: Re: mtree -L is broken due to unneded type=link additions to
發信站: NCTU CSIE FreeBSD Server (Tue Mar 30 09:28:20 2004)
轉信站: ptt!FreeBSD.csie.NCTU!not-for-mail

On Tue, Mar 30, 2004 at 11:26:11AM +0200, Dag-Erling Sm?rgrav wrote:
> It does not break 'make hierarchy', unless you have uncommitted
> patches which add -L to the mtree command line.

I use documented way:
MTREE_FOLLOWS_SYMLINKS= -L
in /etc/make.conf

> The BSD.local.dist commit fixes a problem which has plagued port
> maintainers for years (as witnessed by the number of times people have
> inadvertantly committed plists that included share/nls/POSIX and
> share/nls/en_US.US-ASCII).  I committed the same patch to BSD.usr.dist
> for symmetry, since BSD.local.dist is supposed to be (very nearly) a
> subset of BSD.usr.dist.

This problem already fixed long time ago in /usr/ports/Mk/bsd.port.mk:

                        ${MTREE_CMD} ${MTREE_ARGS} ${PREFIX}/ >/dev/null; 
\
                        if [ ${MTREE_FILE} = "/etc/mtree/BSD.local.dist" 
]; then
 \
                                cd ${PREFIX}/share/nls; \
                                ${LN} -shf C POSIX; \
                                ${LN} -shf C en_US.US-ASCII; \
                        fi; \

So, none of your patches really needed even for old systems, since 
bsd.port.mk is updated semi-automatically. Maybe I not so right about old 
systems, so commit in the appropriate branch in that case instead. This 
problem definitely not exists in -current.

-- 
Andrey Chernov | http://ache.pp.ru/
_______________________________________________
[e-mail] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[e-mail]"

> -------------------------------------------------------------------------- <

發信人: [e-mail] (Dag-Erling Sm鷨grav), 看板: FB_current
標  題: Re: mtree -L is broken due to unneded type=link additions to
發信站: NCTU CSIE FreeBSD Server (Tue Mar 30 09:58:37 2004)
轉信站: ptt!FreeBSD.csie.NCTU!not-for-mail

Andrey Chernov <[e-mail]> writes:
> This problem already fixed long time ago in /usr/ports/Mk/bsd.port.mk:

On the contrary.  The problem is that if you compare a file listing
before and after installing the port, the symlinks will show up in the
"after" list.

DES
--=20
Dag-Erling Sm=F8rgrav - [e-mail]
_______________________________________________
[e-mail] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[e-mail]"

> -------------------------------------------------------------------------- <

發信人: [e-mail] (Andrey Chernov), 看板: FB_current
標  題: Re: mtree -L is broken due to unneded type=link additions to
發信站: NCTU CSIE FreeBSD Server (Tue Mar 30 10:15:10 2004)
轉信站: ptt!FreeBSD.csie.NCTU!not-for-mail

On Tue, Mar 30, 2004 at 12:26:31PM +0200, Dag-Erling Sm?rgrav wrote:
> Andrey Chernov <[e-mail]> writes:
> > This problem already fixed long time ago in /usr/ports/Mk/bsd.port.mk:
> 
> On the contrary.  The problem is that if you compare a file listing
> before and after installing the port, the symlinks will show up in the
> "after" list.

I am not sure I understand situation you describe. As I see, there is a
step in bsd.port.mk when directories are created (and symlinks we discuss
too, just few lines later). Even with your patch, they will be created in
exact the same place in bsd.port.mk - i.e. I see no difference in
before/after installing the port situation with your patch or without it.
Please explain the difference.

-- 
Andrey Chernov | http://ache.pp.ru/
_______________________________________________
[e-mail] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[e-mail]"

> -------------------------------------------------------------------------- <

發信人: [e-mail] (Dag-Erling Sm鷨grav), 看板: FB_current
標  題: Re: mtree -L is broken due to unneded type=link additions to
發信站: NCTU CSIE FreeBSD Server (Tue Mar 30 10:47:52 2004)
轉信站: ptt!FreeBSD.csie.NCTU!not-for-mail

Andrey Chernov <[e-mail]> writes:
> I am not sure I understand situation you describe. As I see, there is a
> step in bsd.port.mk when directories are created (and symlinks we discuss
> too, just few lines later). Even with your patch, they will be created in
> exact the same place in bsd.port.mk - i.e. I see no difference in
> before/after installing the port situation with your patch or without it.
> Please explain the difference.

People use scripts to create empty directory structures so they can
compare before / after file lists to generate plists.

DES
--=20
Dag-Erling Sm=F8rgrav - [e-mail]
_______________________________________________
[e-mail] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[e-mail]"

> -------------------------------------------------------------------------- <

發信人: [e-mail] (Andrey Chernov), 看板: FB_current
標  題: Re: mtree -L is broken due to unneded type=link additions to
發信站: NCTU CSIE FreeBSD Server (Tue Mar 30 10:47:41 2004)
轉信站: ptt!FreeBSD.csie.NCTU!not-for-mail

On Tue, Mar 30, 2004 at 12:51:29PM +0200, Dag-Erling Sm?rgrav wrote:
> People use scripts to create empty directory structures so they can
> compare before / after file lists to generate plists.

I understand it, but I see no difference in before / after file lists with
your patch or without. Could you please demonstrate situation you talk
about in some simple example I can check step-by-step?

I.e. I not state that problem you mention not exists, but your patch not 
fix it too, at least in bsd.port.mk, just because it does nothing which 
not already done by bsd.port.mk

Alternatvely, do you mean direct mtree calls by ports themselfs (i.e. 
bypassing bsd.port.mk)? In this situation ports should be fixed to use 
bsd.port.mk instead.

-- 
Andrey Chernov | http://ache.pp.ru/
_______________________________________________
[e-mail] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[e-mail]"

> -------------------------------------------------------------------------- <

發信人: [e-mail] (Andrey Chernov), 看板: FB_current
標  題: Re: mtree -L is broken due to unneded type=link additions to
發信站: NCTU CSIE FreeBSD Server (Tue Mar 30 11:09:23 2004)
轉信站: ptt!FreeBSD.csie.NCTU!not-for-mail

On Tue, Mar 30, 2004 at 02:59:48PM +0400, Andrey Chernov wrote:
> Alternatvely, do you mean direct mtree calls by ports themselfs (i.e. 
> bypassing bsd.port.mk)? In this situation ports should be fixed to use 
> bsd.port.mk instead.

Alternatively, do you maybe mean that people directly calls mtree by hand
before port installing? It is not supported way to get right directories 
in anycase and not worth to broke mtree -L, of course.

-- 
Andrey Chernov | http://ache.pp.ru/
_______________________________________________
[e-mail] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[e-mail]"

> -------------------------------------------------------------------------- <

發信人: [e-mail] (Dag-Erling Sm鷨grav), 看板: FB_current
標  題: Re: mtree -L is broken due to unneded type=link additions to
發信站: NCTU CSIE FreeBSD Server (Tue Mar 30 13:50:01 2004)
轉信站: ptt!FreeBSD.csie.NCTU!not-for-mail

Andrey Chernov <[e-mail]> writes:
> Alternatively, do you maybe mean that people directly calls mtree by
> hand before port installing? It is not supported way to get right
> directories in anycase and not worth to broke mtree -L, of course.

So what *is* the supported way to create and populate ${PREFIX}?

and why didn't you protest this change when it was discussed on the
lists?  the conclusion of that discussion was "BSD.*.dist doesn't list
symlinks because we thought mtree couldn't handle them"

DES
--=20
Dag-Erling Sm=C3=B8rgrav - [e-mail]
_______________________________________________
[e-mail] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[e-mail]"

> -------------------------------------------------------------------------- <

發信人: [e-mail] (Andrey Chernov), 看板: FB_current
標  題: Re: mtree -L is broken due to unneded type=link additions to
發信站: NCTU CSIE FreeBSD Server (Tue Mar 30 13:50:01 2004)
轉信站: ptt!FreeBSD.csie.NCTU!not-for-mail

On Tue, Mar 30, 2004 at 04:09:02PM +0200, Dag-Erling Sm?rgrav wrote:
> 
> So what *is* the supported way to create and populate ${PREFIX}?

As you can see in bsd.port.mk, it is

make install-mtree

> and why didn't you protest this change when it was discussed on the
> lists?  the conclusion of that discussion was "BSD.*.dist doesn't list
> symlinks because we thought mtree couldn't handle them"

I do that already. Kris ask me in private message about problems symlinks 
can cause in BSD.*.dist. I explain that either -P or -L will be broken. He 
resend my answer to interested parties. Apparently, you was not among 
them.

-- 
Andrey Chernov | http://ache.pp.ru/
_______________________________________________
[e-mail] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[e-mail]"